fix(frontend): enforce supported Node runtime#2284
Open
anirudh5harma wants to merge 1 commit into
Open
Conversation
6345a0a to
219b30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend installs now reject unsupported Node runtimes before npm creates
node_modules, preventing the partial Electron installation reported in #2206. Local setup and every desktop/frontend workflow use Node 24, which is the current supported LTS line and satisfies the frontend dependency engine requirements.This is a contributor-development guardrail, not an end-user launch fix.
ao startopens the released Electron app and its bundled daemon without using local frontend dependencies;npm run devis needed only when running the Electron frontend and Go daemon from source so local changes are exercised together.This supersedes the initial lifecycle-hook implementation in this PR: validation showed that npm runs Electron's dependency
postinstallbefore the root package'spreinstall, so that hook could still leave Electron incomplete. The enforcedenginescontract withengine-strictperforms the check before dependency installation instead.This ports the intent of aoagents/ReverbCode#413 onto the canonical repository with the install-order issue corrected.
Validation
npm ciexits withEBADENGINEand does not createnode_modules.npm cicompletes and Electron's binary/path marker is present.npm run typechecknpm test -- --run(40 files, 370 tests)npm run packagenpx @redwoodjs/agent-ci run --workflow .github/workflows/frontend.yml(1 job passed)git diff --checkPost-Deploy Monitoring & Validation
Watch the first frontend, nightly, testing-build, and release workflows after merge. Healthy behavior is a clean Node 24 install followed by the existing test or packaging steps on each runner; an engine rejection or cross-platform packaging regression is the rollback trigger.